fix: fix mockContext with headers (#153)

mock headers when reuse context.

app/extend/application.js

@@ -37,6 +37,13 @@ module.exports = {
    * ```
    */
   mockContext(data, options) {
+    function mockRequest(req) {
+      for (const key in (data.headers) || {}) {
+        mm(req.headers, key, data.headers[key]);
+        mm(req.headers, key.toLowerCase(), data.headers[key]);
+      }
+    }
+
     options = Object.assign({ mockCtxStorage: true }, options);
     data = data || {};
 
@@ -54,6 +61,7 @@ module.exports = {
 
     if (options.reuseCtxStorage !== false) {
       if (this.currentContext && !this.currentContext[REUSED_CTX]) {
+        mockRequest(this.currentContext.request.req);
         this.currentContext[REUSED_CTX] = true;
         return this.currentContext;
       }
@@ -70,7 +78,7 @@ module.exports = {
       mockCtxStorage: false,
       reuseCtxStorage: false,
     });
-    await this.ctxStorage.run(ctx, fn, ctx);
+    return await this.ctxStorage.run(ctx, fn, ctx);
   },
 
   /**

lib/inject_context.js

@@ -70,14 +70,15 @@ function injectContext(mocha) {
       const app = await appHandler.getApp(suite);
       await app.ready();
       const mockContextFun = app.mockModuleContextScope || app.mockContextScope;
+      let testPassed = false;
       try {
-        await mockContextFun.call(app, async function() {
-          await new Promise((resolve, reject) => {
-            runTests.call(self, suite, errSuite => {
-              if (errSuite) {
-                return reject(errSuite);
+        testPassed = await mockContextFun.call(app, async function() {
+          return await new Promise(resolve => {
+            runTests.call(self, suite, err => {
+              if (err) {
+                return resolve(false);
               }
-              return resolve();
+              return resolve(true);
             });
           });
         });
@@ -86,7 +87,10 @@ function injectContext(mocha) {
         console.error(err);
         return done(suite);
       }
-      return next(i + 1);
+      if (testPassed) {
+        return next(i + 1);
+      }
+      return done(suite);
     }
     next(0).catch(e => {
       e.message = '[egg-mock] inject context error: ' + e.message;

test/fixtures/failed-app/config/config.default.js

@@ -0,0 +1,5 @@
+'use strict';
+
+module.exports = {
+  keys: '123',
+};

test/fixtures/failed-app/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "app"
+}

test/fixtures/failed-app/test/index.test.js

@@ -0,0 +1,32 @@
+const assert = require('assert');
+const { app } = require('../../../../bootstrap');
+
+describe('test/index.test.ts', () => {
+  describe('hook error', () => {
+    beforeEach(() => {
+      assert.fail('failed hook');
+    });
+
+    it('should fail', () => {
+      // eslint-disable-next-line no-undef
+      assert(app.currentContext);
+      assert.fail('failed case');
+    });
+  });
+
+  describe('mockContext failed', () => {
+    before(() => {
+      app.mockContextScope = () => {
+        throw new Error('mockContextScope error');
+      };
+    });
+
+    it('foo', () => {
+      //...
+    });
+
+    it('should not run', () => {
+      console.log('it should not run');
+    });
+  });
+});

test/fixtures/tegg-app/test/tegg_context.test.ts

@@ -30,13 +30,31 @@ describe('test/tegg_context.test.ts', () => {
         tracer: {
           traceId: 'mock_with_data',
         },
+        headers: {
+          'user-agent': 'mock_agent',
+        },
       });
       assert(ctx.tracer.traceId === 'mock_with_data');
+      assert(ctx.get('user-agent') === 'mock_agent');
     });
 
     it('should mock ctx work', () => {
       const traceId = logService.getTracerId();
       assert(traceId === 'mock_with_data');
     });
   });
+
+  describe('mockModuleContextWithHeaders', () => {
+    beforeEach(async () => {
+      await app.mockModuleContext({
+        headers: {
+          'user-agent': 'mock_agent',
+        },
+      });
+    });
+
+    it('should mock ctx work', () => {
+      assert(app.currentContext.get('user-agent') === 'mock_agent');
+    });
+  });
 });

test/inject_ctx.test.js

@@ -15,9 +15,9 @@ describe('test/inject_ctx.test.js', () => {
         EGG_FRAMEWORK: require.resolve('egg'),
       },
     })
-      .debug()
+      // .debug()
       .expect('code', 0)
-      .expect('stdout', /9 passing/)
+      .expect('stdout', /10 passing/)
       .end();
   });
 
@@ -31,9 +31,28 @@ describe('test/inject_ctx.test.js', () => {
     ], {
       cwd: fixture,
     })
-      .debug()
+      // .debug()
       .expect('code', 0)
       // .expect('stdout', /9 passing/)
       .end();
   });
+
+  it('failed case', async () => {
+    const fixture = path.join(__dirname, 'fixtures/failed-app');
+
+    await coffee.fork(require.resolve('egg-bin/bin/egg-bin'), [
+      'test',
+      '-r', require.resolve('../register'),
+      '--full-trace',
+    ], {
+      cwd: fixture,
+      env: {
+        EGG_FRAMEWORK: require.resolve('egg'),
+      },
+    })
+      // .debug()
+      .expect('code', 1)
+      .expect('stderr', /run mock context error: mockContextScope error/)
+      .end();
+  });
 });