Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support mock the same property multiple times #61

Merged
merged 3 commits into from Oct 17, 2017
Merged

Conversation

dead-horse
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@dead-horse dead-horse added the bug label Oct 17, 2017
@codecov-io
Copy link

codecov-io commented Oct 17, 2017

Codecov Report

Merging #61 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #61     +/-   ##
=========================================
+ Coverage   94.28%   94.49%   +0.2%     
=========================================
  Files          11       11             
  Lines         560      563      +3     
=========================================
+ Hits          528      532      +4     
+ Misses         32       31      -1
Impacted Files Coverage Δ
app/extend/application.js 93.37% <100%> (+0.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f0a5e...3bb5033. Read the comment docs.

}
mm(obj, name, () => {
if (data instanceof Error) {
throw data;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个没覆盖?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有可能,我多补一个测试

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@popomore 可以了,没问题合并发个版本吧

@popomore popomore merged commit 9d071b2 into master Oct 17, 2017
@popomore popomore deleted the fix-repeat branch October 17, 2017 09:48
@popomore
Copy link
Member

  • egg-mock@3.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants