Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript support #28

Merged
merged 6 commits into from
Mar 22, 2019
Merged

typescript support #28

merged 6 commits into from
Mar 22, 2019

Conversation

luckyscript
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

增加ts的类型说明，使得typescript下ctx.requests.files可用

@atian25 atian25 requested a review from whxaxes March 12, 2019 07:26
@whxaxes
Copy link
Member

whxaxes commented Mar 12, 2019

感谢 PR ，麻烦按照文档 给 egg 插件提交声明的时候如何编写单测？ 补充一下单测

@luckyscript luckyscript changed the title typescript support WIP typescript support Mar 13, 2019
@codecov
Copy link

codecov bot commented Mar 13, 2019 •
edited
Loading

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #28   +/-   ##
======================================
  Coverage    97.1%   97.1%           
======================================
  Files           5       5           
  Lines         173     173           
======================================
  Hits          168     168           
  Misses          5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be344f...738ac69. Read the comment docs.

@luckyscript luckyscript changed the title WIP typescript support typescript support Mar 13, 2019
@luckyscript luckyscript changed the title typescript support WIP typescript support Mar 13, 2019
@luckyscript luckyscript changed the title WIP typescript support typescript support Mar 14, 2019
whxaxes
whxaxes reviewed Mar 14, 2019
View reviewed changes
index.d.ts Show resolved Hide resolved
@luckyscript luckyscript changed the title typescript support WIP typescript support Mar 14, 2019
@luckyscript luckyscript changed the title WIP typescript support typescript support Mar 14, 2019
whxaxes
whxaxes approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@whxaxes whxaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts 相关的 ci 都过了，挂的是老的单测

@whxaxes
Copy link
Member

whxaxes commented Mar 21, 2019

@luckyscript 有空的话，另外发个 PR 修一下单测？

@luckyscript
Copy link
Contributor Author

@luckyscript 有空的话，另外发个 PR 修一下单测？

好的，明天搞一下。 @whxaxes

@luckyscript
Copy link
Contributor Author

#29 @whxaxes 在这个pr里修了一下。

@whxaxes whxaxes merged commit 33c6b52 into eggjs:master Mar 22, 2019
@whxaxes
Copy link
Member

whxaxes commented Mar 25, 2019

@atian25 发个版本？这个包我没权限

@whxaxes
Copy link
Member

whxaxes commented Apr 29, 2019

ping @atian25

@atian25
Copy link
Member

atian25 commented Apr 29, 2019

给你权限了

@whxaxes
Copy link
Member

whxaxes commented May 1, 2019

2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whxaxes whxaxes whxaxes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luckyscript @whxaxes @atian25