fix: runSchedule should pass args (#47)

eggjs · Apr 29, 2019 · 98a0cf7 · 98a0cf7
1 parent 77fc7d3
commit 98a0cf7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/app.js b/app.js
@@ -68,7 +68,7 @@ module.exports = app => {
 
   // for test purpose
   const directory = [].concat(path.join(app.config.baseDir, 'app/schedule'), app.config.schedule.directory || []);
-  app.runSchedule = schedulePath => {
+  app.runSchedule = (schedulePath, ...args) => {
     // resolve real path
     if (path.isAbsolute(schedulePath)) {
       schedulePath = require.resolve(schedulePath);
@@ -101,6 +101,6 @@ module.exports = app => {
       url: `/__schedule?path=${schedulePath}&${qs.stringify(schedule.schedule)}`,
     });
 
-    return schedule.task(ctx);
+    return schedule.task(ctx, ...args);
   };
 };
diff --git a/test/fixtures/worker/app/schedule/sub/cron.js b/test/fixtures/worker/app/schedule/sub/cron.js
@@ -5,6 +5,6 @@ exports.schedule = {
   cron: '*/5 * * * * *',
 };
 
-exports.task = async function (ctx) {
-  ctx.logger.info('cron');
+exports.task = async function (ctx, ...args) {
+  ctx.logger.info('cron', ...args);
 };
diff --git a/test/schedule.test.js b/test/schedule.test.js
@@ -269,6 +269,16 @@ describe('test/schedule.test.js', () => {
       // console.log(log);
       assert(contains(log, 'customDirectory') === 1);
     });
+
+    it('should run schedule with args', async () => {
+      app = mm.app({ baseDir: 'worker', cache: false });
+      await app.ready();
+      await app.runSchedule('sub/cron', 'test');
+      await sleep(1000);
+      const log = getLogContent('worker');
+      // console.log(log);
+      assert(contains(log, 'cron test') === 1);
+    });
   });
 
   describe('stop schedule', () => {