Add OOM test cases

eggjs · Jul 4, 2017 · 6fb5e65 · 6fb5e65
1 parent 2947b3f
commit 6fb5e65
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/lib/application.js b/lib/application.js
@@ -80,7 +80,7 @@ class Application extends EggApplication {
       this[LOCALS] = {};
     }
 
-    assign(this[LOCALS], [ val ]);
+    assign(this[LOCALS], val);
   }
 
   /**

diff --git a/test/app/extend/application.test.js b/test/app/extend/application.test.js
@@ -77,6 +77,12 @@ describe('test/app/extend/application.test.js', () => {
         .get('/app_same_ref')
         .expect('true');
     });
+
+    it('should app.locals not OOM', () => {
+      return app.httpRequest()
+        .get('/app_locals_oom')
+        .expect('ok');
+    });
   });
 
   describe('app.createAnonymousContext()', () => {

diff --git a/test/fixtures/apps/locals/app/router.js b/test/fixtures/apps/locals/app/router.js
@@ -14,6 +14,16 @@ module.exports = app => {
     this.body = app1 === app2;
   });
 
+  app.get('/app_locals_oom', function*() {
+    for (let i = 0; i < 1000; i++) {
+      app.locals = {
+        // 10MB
+        buff: Buffer.alloc(10 * 1024 * 1024).toString()
+      };
+    }
+    this.body = 'ok';
+  });
+
   app.get('/ctx_same_ref', function*() {
     let ctx1, ctx2;
     this.locals = {