Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

将 instrument 做成插件 #280

Closed
popomore opened this issue Jan 20, 2017 · 3 comments · Fixed by #283
Closed

将 instrument 做成插件 #280

popomore opened this issue Jan 20, 2017 · 3 comments · Fixed by #283
Assignees
@popomore
Labels
core
Milestone
1.0.0

Comments

@popomore
Copy link
Member

现在的功能比较鸡肋，做成插件后可以持续优化而不影响框架。
@popomore popomore added the core label Jan 20, 2017
@popomore popomore added this to the 1.0.0 milestone Jan 20, 2017
@popomore popomore self-assigned this Jan 20, 2017
@atian25
Copy link
Member

atian25 commented Jan 20, 2017

instrument 确实一直没太搞明白定位, 仅在开发期收集时间数据用?

@popomore
Copy link
Member Author

大概是这个意思

@popomore popomore mentioned this issue Jan 20, 2017
Closed
@popomore
Copy link
Member Author

https://github.com/eggjs/egg-instrument

popomore added a commit that referenced this issue Jan 20, 2017
@popomore
feat: remove instrument
912f34c 
Closes #280
@popomore popomore mentioned this issue Jan 20, 2017
Merged
3 tasks
dead-horse pushed a commit that referenced this issue Jan 20, 2017
@popomore @dead-horse
feat: remove instrument (#283)
d0d0a75 
Closes #280
@popomore popomore reopened this Jan 20, 2017
popomore added a commit to eggjs/egg-instrument that referenced this issue Jan 20, 2017
@popomore
feat: first implement
8cbf03a 
Closes eggjs/egg#280
@popomore popomore mentioned this issue Jan 20, 2017
Merged
fengmk2 pushed a commit to eggjs/egg-instrument that referenced this issue Jan 20, 2017
@popomore @fengmk2
feat: first implement (#1)
5aeb382 
Closes eggjs/egg#280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@popomore popomore

Labels
core
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

feat: remove instrument eggjs/egg
2 participants
@atian25 @popomore