Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adjust objects docs #1140

Merged
merged 1 commit into from
Jul 3, 2017
Merged

docs: adjust objects docs #1140

merged 1 commit into from
Jul 3, 2017

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Jul 3, 2017

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from dead-horse July 3, 2017 01:16
@mention-bot
Copy link

@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @kaiye and @zousandian to be potential reviewers.

@@ -122,7 +122,7 @@ Response 是一个**请求级别的对象**,继承自 [Koa.Response]。封装
// app/controller/user.js
module.exports = app => {
return class UserController extends app.Controller {
*fetch () {
* fetch() {
const { app, ctx } = this;
const id = ctx.request.query.id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctx.query,保持跟上面一致

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是讲到 Request,所以才举例。

@codecov
Copy link

codecov bot commented Jul 3, 2017

Codecov Report

Merging #1140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1140   +/-   ##
======================================
  Coverage    99.7%   99.7%           
======================================
  Files          29      29           
  Lines         676     676           
======================================
  Hits          674     674           
  Misses          2       2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0052351...1622862. Read the comment docs.

@dead-horse dead-horse merged commit c7a87a8 into master Jul 3, 2017
@dead-horse dead-horse deleted the docs-object branch July 3, 2017 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants