Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore any key contains "secret" #1156

Merged
merged 1 commit into from Jul 5, 2017
Merged

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jul 5, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @popomore and @shaoshuai0102 to be potential reviewers.

@fengmk2 fengmk2 merged commit 5dc56fa into master Jul 5, 2017
@fengmk2 fengmk2 deleted the more-dump-ignore-keys branch July 5, 2017 02:39
@codecov
Copy link

codecov bot commented Jul 5, 2017

Codecov Report

Merging #1156 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1156      +/-   ##
=========================================
+ Coverage    99.7%   99.7%   +<.01%     
=========================================
  Files          29      29              
  Lines         674     679       +5     
=========================================
+ Hits          672     677       +5     
  Misses          2       2
Impacted Files Coverage Δ
config/config.default.js 100% <ø> (ø) ⬆️
lib/core/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74c8a54...bc4fc16. Read the comment docs.

@fengmk2
Copy link
Member Author

fengmk2 commented Jul 5, 2017

终于可以发版本了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants