Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(core/logger): create logger.md in core #1254

Merged
merged 1 commit into from Aug 17, 2017
Merged

docs(core/logger): create logger.md in core #1254

merged 1 commit into from Aug 17, 2017

Conversation

gztchan
Copy link
Contributor

@gztchan gztchan commented Jul 28, 2017 •
edited

Checklist
  • Create logger.md in docs/source/en/core
  • Translate in English
  • All parts in logger.md should be translated in English
  • Refine grammer, spelling and typography
Affected core subsystem(s)

docs/en/core/logger.md

Description of change

Create translation in English

@gztchan gztchan changed the title docs(core/logger): create logger.md in core [WIP]docs(core/logger): create logger.md in core Jul 28, 2017
@codecov
Copy link

codecov bot commented Jul 28, 2017 •
edited

Codecov Report

Merging #1254 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1254   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          29       29           
  Lines         711      711           
=======================================
  Hits          709      709           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaacd56...6f9e53b. Read the comment docs.

@gztchan gztchan force-pushed the docs-logger branch 2 times, most recently from a7193e4 to fd4d0f5 Compare August 7, 2017 03:53
@gztchan
Copy link
Contributor Author

gztchan commented Aug 15, 2017

@DarrenWong @fengmk2 @dead-horse Please review. 🤣

@gztchan gztchan changed the title [WIP]docs(core/logger): create logger.md in core docs(core/logger): create logger.md in core Aug 15, 2017
@atian25 atian25 merged commit 4daf497 into eggjs:master Aug 17, 2017
popomore pushed a commit that referenced this pull request Aug 17, 2017
docs: auto generate by ci
38ed1c6 
docs(en/core/docs-logger): finish logger.md translation in English (#1254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gztchan @fengmk2 @atian25