fix: use this.options instead of this._options #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
force-pushed
the
fix-deprecate-options
branch
from
86ddc5c
to
8518101
Compare
dead-horse
changed the title
|
冒号是中文的 |
dead-horse
force-pushed
the
fix-deprecate-options
branch
from
8518101
to
4d02b8e
Compare
我说怎么这么奇怪 |
dead-horse
changed the title
popomore
approved these changes
Nov 8, 2017
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 29 29
Lines 715 715
=======================================
Hits 713 713
Misses 2 2
Continue to review full report at Codecov.
|
|
1.10.1 |
popomore
pushed a commit
that referenced
this pull request
Nov 8, 2017
fix: use this.options instead of this._options (#1625)
|
改下 history，egg 发布要提 PR 的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
eggjs/egg-core#127