chore: use Buffer.alloc, Buffer.from. #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1895 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 29 29
Lines 738 738
=======================================
Hits 735 735
Misses 3 3Continue to review full report at Codecov.
|
|
为啥不把 new 去掉 |
popomore
approved these changes
Dec 28, 2017
|
分支 rebase 下，commit message 是 docs |
Since new Buffer() was deprecated since Node.js v6.
aladdin-add
force-pushed
the
chore/buffer
branch
from
3031758
to
cc2f576
Compare
|
确认一下：commit message 改成 |
|
哦，看错了，那改成 |
popomore
pushed a commit
that referenced
this pull request
Dec 29, 2017
test: use Buffer.alloc, Buffer.from. (#1895) Since new Buffer() was deprecated since Node.js v6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since new Buffer() was deprecated since Node.js v6. (https://nodejs.org/dist/latest-v8.x/docs/api/buffer.html#buffer_class_buffer)
Checklist
npm testpassesAffected core subsystem(s)
Description of change