Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add events on application #2039

Merged
merged 3 commits into from Jan 27, 2018
Merged

docs: add events on application #2039

merged 3 commits into from Jan 27, 2018

Conversation

dead-horse
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

app.on('error', (err, ctx) => {
// log
});
app.on('resposne', ctx => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

// log
});
app.on('resposne', ctx => {
const used = Date.now() - ctx.starttime;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加个 request 来记录 starttime ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starttime 是已有的了,这里我加个注释

@codecov-io
Copy link

codecov-io commented Jan 26, 2018

Codecov Report

Merging #2039 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2039   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          29       29           
  Lines         743      743           
=======================================
  Hits          740      740           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebeea2...8e46628. Read the comment docs.

@dead-horse dead-horse merged commit 06e7710 into master Jan 27, 2018
@dead-horse dead-horse deleted the doc-events branch January 27, 2018 02:29
popomore pushed a commit that referenced this pull request Jan 27, 2018
docs: add events on application (#2039)
@atian25
Copy link
Member

atian25 commented Feb 24, 2018

#2020

@atian25 atian25 mentioned this pull request Feb 28, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants