fix: try to use custom function name first #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common use case like:
```js
const fn = function* (ctx) {}
fn.name = `some_${var}_${now)`;
```
fengmk2
commented
Mar 3, 2018
| /* istanbul ignore next */ | ||
| const taskName = scope.name || '-'; | ||
| const taskName = scope._name || scope.name || '-'; |
There was a problem hiding this comment.
必须先使用 _name 才能动态设置 function 的名称
|
@dead-horse 看看，没问题我再提交 2.x 的 |
Codecov Report
@@ Coverage Diff @@
## 1.x #2156 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 29 29
Lines 738 738
=======================================
Hits 736 736
Misses 2 2
Continue to review full report at Codecov.
|
dead-horse
approved these changes
Mar 4, 2018
|
@dead-horse 发版本了吗？我去提交一个 2.x patch |
|
我来发吧，你提 |
fengmk2
added a commit
that referenced
this pull request
Mar 5, 2018
4 tasks
fengmk2
added a commit
that referenced
this pull request
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common use case like:
Checklist
npm testpassesAffected core subsystem(s)
Description of change