Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN translation for style guide doc #2239

Merged
merged 3 commits into from Mar 31, 2018

Conversation

cemremengu
Copy link
Contributor

@cemremengu cemremengu commented Mar 19, 2018

Added en translation for style guide doc #363

@cemremengu cemremengu changed the title Added en translation for style guide doc EN translation for style guide doc Mar 19, 2018
@codecov
Copy link

codecov bot commented Mar 19, 2018

Codecov Report

Merging #2239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2239   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          29       29           
  Lines         749      749           
=======================================
  Hits          746      746           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9c4ec2...e595850. Read the comment docs.

},
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码片段首字母大写了,其他没有什么问题~

@SunShinewyf
Copy link
Contributor

ok @popomore

@popomore popomore merged commit 348ff18 into eggjs:master Mar 31, 2018
popomore pushed a commit that referenced this pull request Mar 31, 2018
docs: EN translation for style guide doc (#2239)
@cemremengu cemremengu deleted the doc-style-guide-en branch March 31, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants