Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dumpConfig support circular json #2394

Merged
merged 2 commits into from Apr 14, 2018
Merged

Conversation

dead-horse
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

https://www.npmjs.com/package/circular-json is widely used

@codecov
Copy link

codecov bot commented Apr 14, 2018

Codecov Report

Merging #2394 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2394      +/-   ##
==========================================
+ Coverage   99.61%   99.61%   +<.01%     
==========================================
  Files          29       29              
  Lines         783      784       +1     
==========================================
+ Hits          780      781       +1     
  Misses          3        3
Impacted Files Coverage Δ
lib/egg.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a489b6...c2750d6. Read the comment docs.

@popomore popomore merged commit 590bd8c into master Apr 14, 2018
@popomore popomore deleted the fix-dump-support-circular branch April 14, 2018 13:17
popomore pushed a commit that referenced this pull request Apr 14, 2018
fix: dumpConfig support circular json (#2394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants