Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typings): define Messenger['on'] and Messenger['once'] #2763

Merged
merged 1 commit into from
Jul 7, 2018

Conversation

waitingsong
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@BaffinLee
Copy link
Contributor

Why not

import { EventEmitter } from 'events'

// ...

export interface Messenger extends EventEmitter {

  // ...

}

It seems better.

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #2763 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2763   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          29       29           
  Lines         829      829           
=======================================
  Hits          826      826           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf8faf...6915e1a. Read the comment docs.

@waitingsong
Copy link
Contributor Author

thanks @BaffinLee

@atian25 atian25 requested a review from whxaxes July 3, 2018 10:45
@waitingsong
Copy link
Contributor Author

ci 怎么老是挂

@popomore
Copy link
Member

popomore commented Jul 7, 2018

需要 rebase 下

@waitingsong
Copy link
Contributor Author

rebased

@popomore popomore merged commit 2ca8f01 into eggjs:master Jul 7, 2018
popomore pushed a commit that referenced this pull request Jul 7, 2018
feat(typings): define Messenger['on'] and Messenger['once'] (#2763)
@waitingsong waitingsong deleted the typings-messenger branch July 7, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants