Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ms dependencies #2875

Merged
merged 1 commit into from
Aug 6, 2018
Merged

fix: add ms dependencies #2875

merged 1 commit into from
Aug 6, 2018

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Aug 6, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2 fengmk2 requested a review from dead-horse August 6, 2018 09:25
@fengmk2
Copy link
Member Author

fengmk2 commented Aug 6, 2018

竟然缺失 ms 的依赖。。。

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 6, 2018

afx publish 又立功

@fengmk2
Copy link
Member Author

fengmk2 commented Aug 6, 2018

image

@atian25
Copy link
Member

atian25 commented Aug 6, 2018

scripts 可以加下:

    "test": "npm run lint -- --fix && egg-bin pkgfiles && npm run test-local",
    "ci": "npm run lint && egg-bin pkgfiles --check && npm run cov"

@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #2875 into 1.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              1.x    #2875   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files          29       29           
  Lines         764      764           
=======================================
  Hits          762      762           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2b991...23590d2. Read the comment docs.

@fengmk2 fengmk2 merged commit e0066bb into 1.x Aug 6, 2018
@fengmk2 fengmk2 deleted the missing-ms-deps branch August 6, 2018 13:54
@fengmk2
Copy link
Member Author

fengmk2 commented Aug 6, 2018

1.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants