docs: fix config and socketio error #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2018
Codecov Report
@@ Coverage Diff @@
## master #2884 +/- ##
==========================================
- Coverage 99.63% 99.39% -0.25%
==========================================
Files 29 29
Lines 824 824
==========================================
- Hits 821 819 -2
- Misses 3 5 +2
Continue to review full report at Codecov.
|
popomore
approved these changes
Aug 9, 2018
|
Test 为啥删了 |
|
天猪昨天讲 test 对应的是测试环境的配置，单元测试是用 unittest 的配置。 |
atian25
reviewed
Aug 9, 2018
| @@ -62,7 +62,10 @@ exports.io = { | |||
| }; | |||
| ``` | |||
|
|
|||
| > 已知默认 `wsEngine` 在 `Chrome` 浏览器中断开连接存在异常，建议优先使用 [uws] | |||
| > <del>已知默认 `wsEngine` 在 `Chrome` 浏览器中断开连接存在异常，建议优先使用 [uws]</del> | |||
atian25
reviewed
Aug 9, 2018
| @@ -17,7 +17,6 @@ This framework supports loading configuration according to the environment and d | |||
| ``` | |||
| config | |||
| |- config.default.js | |||
| |- config.test.js | |||
popomore
pushed a commit
that referenced
this pull request
Aug 9, 2018
docs: fix config and socketio error (#2884) * docs(config): remove test from config list * docs(socketio): format and add desc for uws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change