chroe (TypeScript): Formation errors with missing translations fixed #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #3020 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 29 29
Lines 831 831
=======================================
Hits 829 829
Misses 2 2Continue to review full report at Codecov.
|
BaffinLee
reviewed
Sep 19, 2018
SunShinewyf
reviewed
Sep 20, 2018
1) Some parts still aren't translated into English, so tranlate them all. 2) There're some formations error in JSON snippets, so fix them all.
dead-horse
approved these changes
Sep 20, 2018
popomore
pushed a commit
that referenced
this pull request
Sep 20, 2018
doc (TypeScript): Formation errors with missing translations (#3020) 1) Some parts still aren't translated into English, so tranlate them all. 2) There're some formations error in JSON snippets, so fix them all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts aren't translated into Chinese, so tranlate them
all in the Chinese version.
There're some formations error in JSON snippets in both Chinese and English versions, so fix them all：
e.g——
npm testpasses