Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(typescript.md): Clarify the middleware's usages #3039

Merged
merged 1 commit into from Sep 29, 2018
Merged

doc(typescript.md): Clarify the middleware's usages #3039

merged 1 commit into from Sep 29, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 24, 2018

  1. Clarify the 'ctx' two ways
    (Ref: ctx 不一致? #3037 and egg-cors index.d.ts 缺少设置 #3036).

  2. Fix typo errors in index.d.ts.

  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ghost ghost requested review from whxaxes and atian25 September 24, 2018 03:01
@codecov
Copy link

codecov bot commented Sep 24, 2018

Codecov Report

Merging #3039 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3039   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          29       29           
  Lines         829      829           
=======================================
  Hits          827      827           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf812f...f0db370. Read the comment docs.

@ghost ghost changed the title doc(typescript.md): Clear the middleware's usages doc(typescript.md): Clearify the middleware's usages Sep 24, 2018
@ghost ghost changed the title doc(typescript.md): Clearify the middleware's usages doc(typescript.md): Clarify the middleware's usages Sep 24, 2018
@ghost
Copy link
Author

ghost commented Sep 28, 2018

/cc:@whxaxes

docs/source/zh-cn/tutorials/typescript.md Outdated Show resolved Hide resolved

// 语法糖,相当于:
// const b = Object.assign({}, config, bizConfig);
// return b;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不用特意加注释解释了吧?object spread 现在都已经是众所皆知的规范了 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好,我加上你给的连接

1) Clarify the 'ctx' two ways
(Ref: #3037 and
#3036).
2) Fix typo errors in index.d.ts.
@atian25 atian25 merged commit 3999026 into eggjs:master Sep 29, 2018
@ghost ghost deleted the AddTypescript branch September 29, 2018 03:22
popomore pushed a commit that referenced this pull request Sep 29, 2018
doc(typescript.md): Clarify the middleware's usages (#3039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants