Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix something in articles #3349

Merged
1 commit merged into from Dec 29, 2018
Merged

chore: Fix something in articles #3349

1 commit merged into from Dec 29, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2018

  1. For 'cookie-and-session.md', fix the icon, to make it the same as
    "Error".
  2. For 'cluster-and-ipc.md', Merge the two pharagraphs together, and
    for the Chinese version, translate the English part into Chinese.'
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

1) For 'cookie-and-session.md', fix the icon, to make it the same as
"Error".
2) For 'cluster-and-ipc.md', Merge the two pharagraphs together, and
for the Chinese version, translate the English part into Chinese.'
@ghost ghost requested review from dead-horse, huacnlee and atian25 December 29, 2018 02:41
@atian25 atian25 changed the title Chroe: Fix something in articles chore: Fix something in articles Dec 29, 2018
@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #3349 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3349   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          29       29           
  Lines         844      844           
=======================================
  Hits          842      842           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6a8ce...28af2f2. Read the comment docs.

@ghost ghost merged commit 37e3c1a into eggjs:master Dec 29, 2018
@ghost ghost deleted the FixIntro branch December 29, 2018 03:28
popomore pushed a commit that referenced this pull request Dec 29, 2018
Chroe: Fix something in articles (#3349)

1) For 'cookie-and-session.md', fix the icon, to make it the same as
"Error".
2) For 'cluster-and-ipc.md', Merge the two pharagraphs together, and
for the Chinese version, translate the English part into Chinese.'
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant