Chore: Fix spellings and update typescript compiler version to 3.X #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #3356 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 29 29
Lines 844 844
=======================================
Hits 842 842
Misses 2 2Continue to review full report at Codecov.
|
ghost
changed the title
ghost
mentioned this pull request
3 tasks
whxaxes
approved these changes
Dec 31, 2018
whxaxes
reviewed
Dec 31, 2018
whxaxes
reviewed
Dec 31, 2018
1) For "Sails" in both Chinese and English versions, we should also add the links for them. 2) Union the spellings of "Plugin" instead of "Plug-in".
popomore
pushed a commit
that referenced
this pull request
Dec 31, 2018
Chore: Add missing links for "Sails" and union the spellings of "Plugin" (#3356) 1. For "Sails" in both Chinese and English versions, we should also add the links for them. 2. Union the spellings of "Plugin" instead of "Plug-in". 3. IMPORTANT： Update to the latest version of Typescript, because yard has used "unknown" type, which MUST BE supported since v3.X.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3. IMPORTANT!!
Update to the latest version of Typescript, because yard has used "unknown" type, which MUST BE supported since v3.X.
Here's the screenshot before update:
npm testpasses