Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): array supporting for config.static.dir #3421

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

njugray
Copy link
Contributor

@njugray njugray commented Jan 23, 2019

egg-static plugin supports array of paths for the config property dir.

fix type defined in index.d.ts.

Checklist
  • npm test passes
  • commit message follows commit guidelines

@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #3421 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3421   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          29       29           
  Lines         844      844           
=======================================
  Hits          842      842           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f2e3c...f04ac85. Read the comment docs.

@whxaxes whxaxes self-requested a review January 24, 2019 01:47
@whxaxes whxaxes merged commit e899630 into eggjs:master Jan 24, 2019
popomore pushed a commit that referenced this pull request Jan 24, 2019
fix: array supporting for config.static.dir (#3421)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants