Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add principles for English titles and change all English titles #3444

Merged
8 commits merged into from Feb 14, 2019
Merged

chore: Add principles for English titles and change all English titles #3444

8 commits merged into from Feb 14, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2019

Due to there're too many typo errors in the English titles when translating, we have to force some principles and update them all together.


  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ghost ghost requested review from atian25 and SunShinewyf February 4, 2019 04:06
@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #3444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3444   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          32       32           
  Lines         917      917           
=======================================
  Hits          915      915           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76c230...e197143. Read the comment docs.

MaleDong added 2 commits February 4, 2019 15:40
Due to there're too many typo errors in the English titles when
translating, we have to force some principles and update them all
together.
CONTRIBUTING.zh-CN.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/source/zh-cn/core/httpclient.md Outdated Show resolved Hide resolved
docs/source/en/tutorials/socketio.md Show resolved Hide resolved
docs/source/en/faq.md Outdated Show resolved Hide resolved
Maledong added 4 commits February 13, 2019 09:46
Add this missing '助词'
1. "some" => "a".
2. change the translation
Add '``' on app and ctx
"Why my config doesn't work?" => "Why my config not work?"
CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/source/en/faq.md Outdated Show resolved Hide resolved
docs/source/en/tutorials/socketio.md Show resolved Hide resolved
docs/source/en/tutorials/socketio.md Show resolved Hide resolved
Maledong added 2 commits February 14, 2019 06:45
fix for "or the name of a plugin"
fix for "Why does my config not work"
@SunShinewyf
Copy link
Contributor

@atian25 done~

@ghost ghost merged commit ae5f56f into eggjs:master Feb 14, 2019
@ghost ghost deleted the FixTrans branch February 14, 2019 08:20
popomore pushed a commit that referenced this pull request Feb 14, 2019
chore: Add principles for English titles and change all English titles (#3444)

Due to there're too many typo errors in the English titles when translating, we have to force some principles and update them all together.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants