New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add principles for English titles and change all English titles #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3444 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 32 32
Lines 917 917
=======================================
Hits 915 915
Misses 2 2 Continue to review full report at Codecov.
|
Due to there're too many typo errors in the English titles when translating, we have to force some principles and update them all together.
SunShinewyf
reviewed
Feb 12, 2019
Add this missing '助词'
1. "some" => "a". 2. change the translation
Add '``' on app and ctx
"Why my config doesn't work?" => "Why my config not work?"
SunShinewyf
reviewed
Feb 13, 2019
fix for "or the name of a plugin"
fix for "Why does my config not work"
@atian25 done~ |
atian25
approved these changes
Feb 14, 2019
ghost
deleted the
FixTrans
branch
February 14, 2019 08:20
popomore
pushed a commit
that referenced
this pull request
Feb 14, 2019
chore: Add principles for English titles and change all English titles (#3444) Due to there're too many typo errors in the English titles when translating, we have to force some principles and update them all together.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to there're too many typo errors in the English titles when translating, we have to force some principles and update them all together.
npm test
passes