feat: support config.maxProxyCount to help get the real client ip #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@popomore 先看这个，在 egg 层支持吧，我等下补个文档把代理相关的配置都说明一下。 |
dead-horse
changed the title
dead-horse
changed the title
popomore
reviewed
Apr 11, 2019
app/extend/request.js
Outdated
|
|
||
| // if maxProxyCount present, only keep `maxProxyCount + 1` ips | ||
| // [ illegalIp, clientRealIp, proxyIp1, proxyIp2 ...] | ||
| if (this.app.config.maxProxyCount) this[IPS] = this[IPS].slice(-(this.app.config.maxProxyCount + 1)); |
There was a problem hiding this comment.
this.app.config.maxProxyCount > 0
这样就不用做类型判断了
Codecov Report
@@ Coverage Diff @@
## master #3612 +/- ##
======================================
Coverage 100% 100%
======================================
Files 32 32
Lines 919 921 +2
======================================
+ Hits 919 921 +2
Continue to review full report at Codecov.
|
dead-horse
force-pushed
the
fix-client-ip
branch
from
101d2ee
to
54486c7
Compare
popomore
approved these changes
Apr 11, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.