docs: add how to config egg behind a proxy #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atian25
reviewed
Apr 11, 2019
| exports.ipHeaders = 'X-Real-Ip, X-Forwarded-For'; | ||
| ``` | ||
|
|
||
| ### `config.maxProxyCount` |
There was a problem hiding this comment.
这些配置是不是考虑加载一个 config.xx 上，全挂到根下，回头不好管理，和用户的冲突啥的
There was a problem hiding this comment.
感觉可以考虑一波大版本了：
- 单进程
- config 异步
- 一些历史包袱抛掉
atian25
reviewed
Apr 11, 2019
| @@ -0,0 +1,72 @@ | |||
| title: 前置代理模式 | |||
There was a problem hiding this comment.
这个还是单独放一章吧，很多内容是配置反向代理的，不算安全相关
There was a problem hiding this comment.
嗯，可以是单独文章，不过回头重构的文档里面我放到安全目录，而不是在教程目录。新文档里面的安全是拆成多个文章了。
这里可以先这样。
popomore
pushed a commit
that referenced
this pull request
Apr 11, 2019
docs: add how to config egg behind a proxy (#3614)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change