Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove @types/urllib #3732

Merged
merged 1 commit into from Jun 5, 2019
Merged

chore: remove @types/urllib #3732

merged 1 commit into from Jun 5, 2019

Conversation

atian25
Copy link
Member

@atian25 atian25 commented May 29, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
npm WARN deprecated @types/urllib@2.33.0: This is a stub types definition. urllib provides its own type definitions, so you do not need this installed.

@atian25 atian25 requested a review from whxaxes May 29, 2019 06:07
@whxaxes
Copy link
Member

whxaxes commented Jun 5, 2019

我重跑一下 ci 看看

@whxaxes
Copy link
Member

whxaxes commented Jun 5, 2019

ci 挂了是 lifecycle 的问题，这个 PR 我先合了

@whxaxes whxaxes merged commit b1cb533 into master Jun 5, 2019
@whxaxes whxaxes deleted the atian25-patch-1 branch June 5, 2019 12:07
popomore pushed a commit that referenced this pull request Jun 5, 2019
docs: auto generate by ci
40fb58e 
chore: remove @types/urllib (#3732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whxaxes whxaxes whxaxes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@atian25 @whxaxes