feat: support config.maxIpsCount #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
commented
Oct 28, 2019
| * @member {Integer} Config#maxIpsCount | ||
| * @default | ||
| * @since 2.25.0 | ||
| */ |
There was a problem hiding this comment.
之前的实现其实有问题，配置替换成和 koa 的一致。
fengmk2
approved these changes
Oct 28, 2019
fengmk2
reviewed
Oct 28, 2019
app/extend/request.js
Outdated
| // Compatible with maxProxyCount logic (previous logic is wrong, only for compatibility with legacy logic) | ||
| if (!maxIpsCount && this.app.config.maxProxyCount) maxIpsCount = this.app.config.maxProxyCount + 1; | ||
|
|
||
| if (maxIpsCount) { |
Codecov Report
@@ Coverage Diff @@
## master #4014 +/- ##
======================================
Coverage 100% 100%
======================================
Files 34 34
Lines 945 947 +2
======================================
+ Hits 945 947 +2
Continue to review full report at Codecov.
|
popomore
pushed a commit
that referenced
this pull request
Oct 28, 2019
feat: support config.maxIpsCount (#4014)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change