test: fix the unstable for windows #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After investigation for a while for windows, it seems we should delay for about 1 sec before the "assert" can find the actual error logged into the file.
|
Test on my old PC and it gets passed twice. |
|
@MaledongGit egg 的 Windows 环境开发者有你有福。 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5195 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 35 35
Lines 3489 3489
Branches 512 512
=======================================
Hits 3484 3484
Misses 5 5 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 3.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigation for a while for windows, it seems we should delay for about 1 sec before the "assert" can find the actual error logged into the file.
npm testpasses