Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused jsonp delegate #739

Merged
merged 1 commit into from Apr 11, 2017
Merged

fix: remove unused jsonp delegate #739

merged 1 commit into from Apr 11, 2017

Conversation

dead-horse
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @popomore and @atian25 to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 11, 2017

Codecov Report

Merging #739 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #739   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         640    640           
=====================================
  Hits          640    640
Impacted Files Coverage Δ
app/extend/context.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33523d...1aa2b33. Read the comment docs.

@fengmk2
Copy link
Member

fengmk2 commented Apr 11, 2017

jsonp is a middleware now.

@fengmk2 fengmk2 merged commit 26efa42 into master Apr 11, 2017
@fengmk2 fengmk2 deleted the remove-ctx-jsonp branch April 11, 2017 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants