Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a link to issue template #853

Merged
merged 3 commits into from
May 9, 2017
Merged

docs: Add a link to issue template #853

merged 3 commits into from
May 9, 2017

Conversation

popomore
Copy link
Member

@popomore popomore commented May 5, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse to be a potential reviewer.

1. 我们推荐如果是小问题(错别字修改,小的 bug fix)直接提交 PR。
2. 如果是一个 BUG,请提供:复现步骤,错误日志以及相关配置,并尽量填写下面的模板中的条目。
3. 如果是一个新需求,请提供:详细需求描述,最好是有伪代码实现。
1. 在提问之前推荐阅读 https://zhuanlan.zhihu.com/p/25795393
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个得 @atian25 来修下文案

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改什么文案?

@codecov
Copy link

codecov bot commented May 5, 2017

Codecov Report

Merging #853 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #853   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     28           
  Lines         667    667           
=====================================
  Hits          667    667

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01d30e...060c1c8. Read the comment docs.

@atian25
Copy link
Member

atian25 commented May 8, 2017

优化下了,再看看

-->

* **Node Version**:
* **Egg Version**:
* **Plugin Name**:
* **Plugin Version**:
* **Platform**:
* **Mini Showcase Repository**: http://
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后面不要加这个 http:// 吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@atian25 atian25 merged commit e55a134 into master May 9, 2017
@atian25 atian25 deleted the doc branch May 9, 2017 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants