test: node 8 #976
Merged
test: node 8 #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore, @dead-horse and @atian25 to be potential reviewers. |
fengmk2
commented
Jun 1, 2017
| @@ -72,7 +74,9 @@ describe('test/lib/plugins/security.test.js', () => { | |||
| }); | |||
|
|
|||
| it('should check csrf on other.json', () => { | |||
| return request(app.callback()) | |||
| // use prod env to ignore extends properties like frames | |||
| mm(app.config, 'env', 'prod'); | |||
There was a problem hiding this comment.
@dead-horse 还是让 egg-onerror 保留那些信息吧，开发阶段有用
|
好几个库挂了，我修一下 |
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 28 28
Lines 675 675
=======================================
Hits 664 664
Misses 11 11Continue to review full report at Codecov.
|
|
onerror 在 unittest 环境是不是不要返回 frame，不然应用也要改一堆 |
+1, @okoala |
|
eggjs/egg-onerror#14 直接去掉 error detail |
dead-horse
approved these changes
Jun 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change