Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date_format arg to specify format string for dates #95

Merged
merged 2 commits into from
Feb 2, 2020

Conversation

kevinjfoley
Copy link
Contributor

Tested against fixtures/checking.ofx and fixtures/paypal.csv with:

fixtures/checking.ofx
fixtures/checking.ofx -y "%Y-%m-%d"
fixtures/paypal.csv -a "test"
fixtures/paypal.csv -y "%Y-%m-%d" -a "test"

@egh
Copy link
Owner

egh commented Feb 1, 2020

Thanks very much @kevinjfoley ! This is great. Do you think we need the full date-format code, or would simply allowing - or / satisfy your use case? I know ledger allows any date format, but I'm curious how many people use non-standard date formats.

@kevinjfoley
Copy link
Contributor Author

Thanks very much @kevinjfoley !

My pleasure!

Do you think we need the full date-format code, or would simply allowing - or / satisfy your use case?

My only use case for this is to be able to use - in my dates instead of / so some kind of option like date-separator would meet my needs.

However I figure allowing a full date format code gives more flexibility, some people may prefer %m/%d/%Y which this would allow for. Is there a downside to allowing a full code that
you're worried about?

@egh
Copy link
Owner

egh commented Feb 2, 2020

@kevinjfoley It just seemed a little more complicated, but it does add the additional flexibility, so that's fine with me. Thanks again!

Copy link
Owner

@egh egh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants