Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better assert helpers for working with list of IDiff's #84

Closed
egil opened this issue Mar 31, 2020 · 4 comments
Closed

Better assert helpers for working with list of IDiff's #84

egil opened this issue Mar 31, 2020 · 4 comments
Labels
backlog Enhancements which are relevant but not a priority at the moment. enhancement New feature or request help wanted Extra attention is needed input needed When an issue requires input or suggestions

Comments

@egil
Copy link
Member

egil commented Mar 31, 2020

The current assert helpers, such as ShouldHaveChanges, could use some work. There are multiple scenarios that should be supported. Consider moving to its own library, perhaps related to AngleSharp Diffing.

Input and feedback needed!
@egil egil added enhancement New feature or request help wanted Extra attention is needed input needed When an issue requires input or suggestions labels Mar 31, 2020
@egil
Copy link
Member Author

egil commented Apr 29, 2020

Related: #22

@egil egil added the backlog Enhancements which are relevant but not a priority at the moment. label Aug 15, 2020
@egil
Copy link
Member Author

egil commented Aug 15, 2020

I am moving this to the backlog for now, as this is more of a nice to have, which provide helpers for users working with IDiff types.

@SimonCropp
Copy link
Contributor

note that Verify.AngleSharp supports this https://github.com/VerifyTests/Verify.AngleSharp#diff-results

@egil
Copy link
Member Author

egil commented May 26, 2022

Superseeded by #738

@egil egil closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Enhancements which are relevant but not a priority at the moment. enhancement New feature or request help wanted Extra attention is needed input needed When an issue requires input or suggestions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@egil @SimonCropp