Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reassign numeric local checkers #12

Closed
egnha opened this issue Mar 13, 2017 · 0 comments
Closed

Reassign numeric local checkers #12

egnha opened this issue Mar 13, 2017 · 0 comments

Comments

@egnha
Copy link
Owner

egnha commented Mar 13, 2017 •
edited
Loading

purrr::is_numeric and purrr::is_scalar_numeric are deprecated in purrr (>= 0.2.2.9000) since they don't check what you might naively think; in particular, purrr::is_numeric yields TRUE for factors.

Replace these predicates by their base R equivalents in the definitions of vld_numeric and vld_scalar_numeric.
egnha added a commit that referenced this issue Mar 14, 2017
@egnha
Reassign numerical local checkers (#12)
86a6705
@egnha egnha closed this as completed Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@egnha