Store metadata about user and Gist #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgierer12
commented
Jan 28, 2018
src/views/EditorPage.vue
Outdated
| @@ -119,6 +119,8 @@ export default { | |||
| } | |||
| }, | |||
| mounted() { | |||
| this.$store.dispatch('setUser') | |||
There was a problem hiding this comment.
Not sure if this is the right place to fetch user details, any better place for this @egoist?
egoist
requested changes
Jan 29, 2018
src/store/index.js
Outdated
| commit('SET_GIST_META', data) | ||
| }, | ||
| async setUser({ commit, state }) { | ||
| const data = await api('user', state.githubToken) |
There was a problem hiding this comment.
seems we don't need to setUser when there's no token
src/views/EditorPage.vue
Outdated
| @@ -119,6 +119,8 @@ export default { | |||
| } | |||
| }, | |||
| mounted() { | |||
| this.$store.dispatch('setUser') | |||
There was a problem hiding this comment.
maybe we don't need to call setUser when app is mounted, just save the user meta to localStorage after login?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the complete API response for Gist and user calls, so we can later access things like logged in username, Gist owner, and many more.
This will allow for things like:
and so on
This PR also pulls out the logic for GH API calls into a util module