Skip to content
This repository has been archived by the owner on Dec 6, 2021. It is now read-only.

Publish type definitions #497

Closed
egoist opened this issue Dec 8, 2018 · 6 comments
Closed

Publish type definitions #497

egoist opened this issue Dec 8, 2018 · 6 comments

Comments

@egoist
Copy link
Owner

egoist commented Dec 8, 2018

Someone interested in adding @types/poi to https://github.com/DefinitelyTyped/DefinitelyTyped? :P

@egoist
Copy link
Owner Author

egoist commented Dec 13, 2018

We can start with adding the type for Poi config:

poi.config.js:

/** @type {import('poi').Config} */
const config = {}

module.exports = config

@egoist egoist pinned this issue Dec 15, 2018
@egoist egoist added this to To do in 12 Jan 25, 2019
@bolasblack
Copy link
Contributor

bolasblack commented Mar 30, 2019

Hi I have a question, why not put declaration file(.d.ts file) in poi npm package, but put it in @types/poi? In this case, the user does not need to install another package for type checking and autocompletion.

@egoist
Copy link
Owner Author

egoist commented Mar 30, 2019

@bolasblack that will add a few mega bytes to Poi 😅

@bolasblack
Copy link
Contributor

@egoist I created a PR: DefinitelyTyped/DefinitelyTyped#34424, I think you can review the code and confirm that there is no problem with the type definition I wrote.

@bolasblack
Copy link
Contributor

Finally, DefinitelyTyped/DefinitelyTyped#34424 merged

@egoist
Copy link
Owner Author

egoist commented Apr 16, 2019

woot, thanks 😄

@egoist egoist closed this as completed Apr 16, 2019
12 automation moved this from To do to Done Apr 16, 2019
@egoist egoist unpinned this issue May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
12
  
Done
Development

No branches or pull requests

2 participants