Skip to content
This repository has been archived by the owner on Dec 6, 2021. It is now read-only.

Add memoryLimit option to @poi/plugin-typescript plugin #675

Closed
adamsvystun opened this issue Mar 18, 2020 · 3 comments · Fixed by #676
Closed

Add memoryLimit option to @poi/plugin-typescript plugin #675

adamsvystun opened this issue Mar 18, 2020 · 3 comments · Fixed by #676

Comments

@adamsvystun
Copy link
Contributor

fork-ts-checker-webpack-plugin webpack plugin that is used by @poi/plugin-typescript has the option of setting a memory limit for the type checking process. But this option is not accessible through the plugin settings. Can it by made accessible?

This is a small change. I can submit PR if necessary.

@egoist
Copy link
Owner

egoist commented Mar 18, 2020

Yes, PR welcome. We can make a tscheckerOptions option for that

@egoist
Copy link
Owner

egoist commented Mar 18, 2020

btw you can modify ts-checker options in poi.config.js like this:

module.exports = {
  chainWebpack(config) {
    config.plugin('fork-ts-checker')
      .tap(([options]) => [Object.assign(options, {
        memoryLimit: 512
      })])
  }
}

It's a little verbose so exposing the option might be a good idea.

@adamsvystun
Copy link
Contributor Author

Thanks for the workaround! I submitted PR for tscheckerOptions #676.

egoist added a commit that referenced this issue Mar 18, 2020
* feat(plugin-typescript): add tscheckerOptions (#675)

* docs(plugin-typescript): add tscheckerOptions to README.md

* add link to option docs

Co-authored-by: Kevin Titor <0x142857@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants