Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chrome path #95

Closed
wants to merge 4 commits into from
Closed

Add chrome path #95

wants to merge 4 commits into from

Conversation

murilobd
Copy link

If you accept the PR for taki to accept chrome custom path, this PR adds this option to presite.
Then, it will be possible to pre-render a website on netlify (related to #93 )

@murilobd murilobd mentioned this pull request Oct 16, 2020
@egoist
Copy link
Owner

egoist commented Oct 16, 2020

Actually it would be better to just make taki to respect CHROME_PATH environment variable cuz that seems to be a convention.

@murilobd
Copy link
Author

No need for this as CHROME_PATH works fine on netlify

@murilobd murilobd closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants