Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SWC and Terser minification clash #881

Merged
merged 1 commit into from Jun 16, 2023
Merged

Conversation

Thisen
Copy link
Contributor

@Thisen Thisen commented Apr 12, 2023

This PR fixes an issue when targeting es5 and using terser for minification.

Currently when minify === true in tsup options, SWC will mangle the code. It leads to unexpected behavior, as you would believe that you have fine-grained control with Terser.

@codesandbox
Copy link

codesandbox bot commented Apr 12, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 6:53am

Copy link

@tlaitinen tlaitinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@egoist egoist merged commit 23e25cd into egoist:dev Jun 16, 2023
4 checks passed
@github-actions
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Thisen Thisen deleted the patch-1 branch July 24, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants