bundle Prism in the ESM version to prevent Vite issues #42
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS: we can remove `--bundle-node-modules` again once the ESM version of Prism comes out.
|
fixes: #40 |
|
@egoist kindly review this small PR with great benefit : ) |
|
After SO MUCH debugging because my own lib didn't work in Vite this is the problem.... pls @egoist review and accept this |
|
I create a fork with the dist of your fork, so anyone can install directly https://github.com/Nisgrak/vue-prism-component |
|
@Nisgrak i also wasted about 4+ hours on this issue, but I learned alittre bit while finding out what exactly was going wrong. : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #40
PS: we can remove
--bundle-node-modulesagain once the ESM version of Prism comes out.