Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed formatting problems, example and JSDoc #129

Conversation

Alexandrshy
Copy link
Contributor

Fixed:

  1. The implementation of the examples to prevent rewrite/full cleaning of the original array;
  2. Code formatting;
  3. Moved the recursion example to the ES6 directory, since this solution was written in ES6.

P.S. Maybe worth removing the separation between ES6 and JS? ES6 was released more than 4 years ago and it makes no sense to separate these decisions, I can do it in the next PR, what do you think about it?

@egonSchiele
Copy link
Owner

Hello, sorry for my super-late response. It looks like there are some conflicts that need to be resolved before merge, could you take a look?

Adit

@Alexandrshy
Copy link
Contributor Author

Hello, done

@egonSchiele egonSchiele merged commit c029201 into egonSchiele:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants