-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter support? #45
Comments
I've got a WIP implementation of chapter support on my fork: |
Oh sweet! Any plans on sending a PR for that? |
I'm going to be testing it from my fork for a while. There's also a lot of cleanup needed to bring it up to the standards for the rest of the app, and I haven't written any tests yet. |
I've been starting to add CHAP support, but you've implemented CTOC as well, @mattbasta, awesome! Since this is more complete I would rather help fix this up rather than keep working on my version. What can I do to help? (Should we take this to your fork?) |
Happy to collaborate and go over PRs (or add someone as a collaborator on my fork), but I won't have a huge amount of time to write code for this in the coming weeks. My fork was mainly to scratch an urgent itch for one of my users. Getting that back upstream would be great, but it's not my top priority at the moment. |
I'd love to have this upstream! I'll try to find some time in the coming weeks to start taking a look. |
any update on chapter support? was just looking to include this in my app. |
Any news regarding chapter support. Chapters have become extremely common, and jsmediatags is great for reading them but writing is a different matter altogether. We have a platform where we get the mp3 files with chapters and a placeholder for a sponsor, which hasn't been recorded yet at the time the file is stored. We wanted to add the sponsor and readjust all chapters and chapter art accordingly. The math itself and the mp3 edition is simple enough, but rearranging the chapters is actually an incredible pain as of now. It would be ideal to be able to get the whole tag bundle in a json, modify the timestamps from the sponsor marker onwards and reapply them to the modified audio file. |
Would be great to have chapters supported.
Any idea how hard that would be to add support for?
The text was updated successfully, but these errors were encountered: