Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and add TypeScript declaration file #89

Merged
merged 5 commits into from
Feb 15, 2024

Conversation

altearius
Copy link
Contributor

This addresses #78

Types being picked up by VSCode:

image

image

Screenshot showing the results of passing through the TypeScript compiler; note ImageType.CoverFront is correctly replaced.

image

browser-id3-writer.d.ts Outdated Show resolved Hide resolved
browser-id3-writer.d.ts Outdated Show resolved Hide resolved
browser-id3-writer.d.ts Outdated Show resolved Hide resolved
browser-id3-writer.d.ts Outdated Show resolved Hide resolved
Copy link
Owner

@egoroof egoroof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@egoroof egoroof merged commit 7d3f3d3 into egoroof:master Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants