Performance improvements #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunlalwani
requested review from
kavi-egov,
talele08 and
a team
as code owners
DeepCode's analysis on #d79fbc found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin. |
|
Kudos, SonarCloud Quality Gate passed!
|
talele08
reviewed
Jul 22, 2021
| public List<Boundary> getAllBoundariesByIdsAndTypeAndNumberAndCodeAndTenant( | ||
| BoundarySearchRequest boundarySearchRequest) { | ||
|
|
||
| return boundaryRepository.getAllBoundariesByIdsAndTypeAndNumberAndCodeAndTenant(boundarySearchRequest); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Adding spring cache might give problems when we run more than one pod. For example, in case of _update it will evict cache only in the particular pod which handled that particular request. We will have to figure out such use cases and might have to use centralized caching using redis instead to avoid these problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvements for caching merged to Digit 2.5