Fix high cost overflowing #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be nice to make cost have type |
|
@yihozhang That makes sense to me. Would these unwanted constructors then never be extracted? |
saulshanabrook
added a commit
to egraphs-good/egglog-python
that referenced
this pull request
May 2, 2023
|
Yes that's what I'm thinking |
|
@yihozhang That sounds better to me than this PR, so that these temporary variables are never returned. |
|
Ok, closing this for now in favor of that future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the size of the HIGH_COST so that it won't overflow when added to other costs.
Instead of using all the bits, it will only use half of them, which should still give it a pretty high cost but also plenty of room to grow.