Cleanup from terms PR #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c578a77.
oflatt
commented
Jul 31, 2023
| @@ -45,6 +45,20 @@ impl MapSort { | |||
| } | |||
| } | |||
|
|
|||
| impl MapSort { | |||
| pub fn presort_names() -> Vec<Symbol> { | |||
There was a problem hiding this comment.
Presort names is so bad bad but I'm not sure how else to get presort names
ezrosent
reviewed
Aug 1, 2023
src/sort/vec.rs
Outdated
| @@ -69,21 +83,8 @@ impl Sort for VecSort { | |||
| result | |||
| } | |||
|
|
|||
| fn canonicalize(&self, value: &mut Value, unionfind: &UnionFind) -> bool { | |||
There was a problem hiding this comment.
Why is this getting backed out? Don't we still want to canonicalize vectors?
There was a problem hiding this comment.
Oof, good catch, it shouldn't be backed out.
We really need better testing for containers
There was a problem hiding this comment.
Actually apparently container rebuilding is just completely broken in main, see #165.
I'll restore the canonicalize code though
Closed
This was referenced Aug 20, 2023
saulshanabrook
added a commit
to saulshanabrook/egg-smol
that referenced
this pull request
Aug 23, 2023
In egraphs-good#176 the `ExtractCommand` is now created with `query-extract` instead of `extract`.
This was referenced Aug 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Sorry all these changes are together, it was tough to get them from my terms PR.