Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part extraction issue #181

Closed
msphn opened this issue Oct 24, 2018 · 6 comments
Closed

Part extraction issue #181

msphn opened this issue Oct 24, 2018 · 6 comments
Labels
Projects

Comments

@msphn
Copy link

msphn commented Oct 24, 2018

The following message is separating parts incorrectly:

    {
        $parts = explode('@', $email);
        $this->domainPart = $this->domainPartParser->getDomainPart();
        $this->localPart = $parts[0];
    }

According to rfc3696 @ is allowed if quoted or wrapped in double quotes.

Examples:
Abc\@def@example.com
"Abc@def"@example.com

@egulias egulias added the bug label Oct 28, 2018
@egulias
Copy link
Owner

egulias commented Oct 28, 2018

You're right @msphn :) . This code was a simplification to extract the parts, it has a lot of place for improvement.

@msphn
Copy link
Author

msphn commented Oct 29, 2018

@egulias I did same in the past :) Most of the time it works fine.

@georgringer
Copy link

"Abc@def"@example.com seems to be valid in latest version, FYI

@egulias egulias added this to To do in V3 Jun 7, 2020
@egulias egulias moved this from To do to In progress in V3 Sep 26, 2020
@egulias egulias moved this from In progress to Done in V3 Oct 3, 2020
@egulias
Copy link
Owner

egulias commented Dec 29, 2020

Fixed in v3.

@nhovratov
Copy link

Abc\@def@example.com still doesn't seem to work

@egulias
Copy link
Owner

egulias commented Jul 13, 2022

Hi @nhovratov , this is a 2 yars old issue. Do you mind opening a new one with your concrete incident? A failing test case would be super useful. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
V3
  
Done
Development

No branches or pull requests

4 participants