Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch-all validation #248

Closed
rrjanbiah opened this issue Jun 22, 2020 · 5 comments
Closed

Catch-all validation #248

rrjanbiah opened this issue Jun 22, 2020 · 5 comments
Projects

Comments

@rrjanbiah
Copy link

Only an idea. Trumail has used some nice trick to validate catch-all address https://github.com/trumail/trumail/blob/master/verifier/deliverabler.go#L193 (May check their website demo)

@egulias
Copy link
Owner

egulias commented Jul 20, 2020

Hi!
While they would be worrisome for sure, they are probably semantically correct. The lib is for validating the address composition, not for spam check or similar features.
With this information, do you think I'd still make sense the feature on the EmailValidator?

@rrjanbiah
Copy link
Author

@egulias Up to you. But, I believe EmailValidator is doing more than RFC semantic validation.

@egulias
Copy link
Owner

egulias commented Aug 15, 2020

@rrjanbiah I'd like to understand your point of view. Could you please elaborate?

@rrjanbiah
Copy link
Author

@egulias In PHP, this is the most popular package. It has more than RFC semantic validation. So, IMHO, below are still valid candidates:

@egulias egulias added this to To do in V3 via automation Sep 6, 2020
@egulias egulias moved this from To do to Nice to Have in V3 Nov 14, 2020
@egulias
Copy link
Owner

egulias commented Dec 30, 2020

Hi @rrjanbiah ,
Yes, took your suggestions and made them space in v3 of the library by adding the possibility to have "extra" validations (check the Contributing file).
While I'll do my part to add them, I'm more than happy to review and merge implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
V3
  
Nice to Have
Development

No branches or pull requests

2 participants