Allow for escaped quote in quoted text #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI i think the right solution for #101 and #68 is to let the parser return a full AST for the given email address, from which you can reconstruct the email adress exactly as given. I.e. it allows for formatters. That way you would also have warnings per part as currently domain warnings can override local warnings, which is fine from a validation POV but we lose context. |
|
It probably is. Lets chat on #101 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://en.wikipedia.org/wiki/Email_address#Local_part we should expect an email address like
"very.(),:;<>[]\".VERY.\"very@\\ \"very\".unusual"@strange.example.com.I.e. an escaped quote in a quoted text part, currently the local part parser reaches until
"very.(),:;<>[]\.